-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private Routes Guard #483
Merged
Merged
Private Routes Guard #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
A percentage of a sprint. 2.1 hours.
GREI Re-arch
GREI re-architecture-related
SPA: Permissions
FY25 Sprint 5
FY25 sprint 5
labels
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor question about Spinner.
ekraffmiller
approved these changes
Sep 19, 2024
ChengShi-1
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything work well1. I checked that an unauthorized user couldn't access pages through url. Approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 5
FY25 sprint 5
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Permissions
SPA.Q3
Not related to any specific Q3 feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds protection for routes intended for logged-in users only.
If a not logged in user arrives at a protected path, the user will be automatically redirected to the JSF login page.
It currently applies to the following routes:
/spa/collections/[ownerCollectionId]/create
/spa/datasets/edit-metadata?persistentId=[pid]
/spa/datasets/upload-files?persistentId=[pid]
/spa/account?tab=apiToken
or/spa/account
Which issue(s) this PR closes:
Special notes for your reviewer:
N/A
Suggestions on how to test this:
Create a collection and a dataset.
Go to the 5 pages mentioned above, copy the URL and open it in another browser or in an incognito window (to test without being logged in) and confirm that you are redirected to the JSF login page.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No, it only shows a spinner if a protected route is loading the user session.