Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/319 new collection page #433

Merged
merged 32 commits into from
Jul 24, 2024
Merged

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:
Adds section/page to create a new collection and integrates with the js-dataverse use case.

Which issue(s) this PR closes:

Closes #319

Special notes for your reviewer:

  • This PR does not contemplate checking whether or not the user can create a collection within a non-root collection, nor if the user is authenticated or not.
  • It only sends required fields since the use case only contemplates required fields to create a collection for now.
  • A feature has been added to suggest an identifier to the user based on the collection name entered.

Suggestions on how to test this:
Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
  5. Navigate with cd dev-env.
  6. Start the environment using ./run-env.sh unstable.
  7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the New Collection page

  1. Log in.
  2. From the root collection page click on Add Data => New Collection button.
  3. Check that Host Collection, Collection Name, Affiliation and Email fields are correctly pre-filled with your account data.
  4. Apply the suggestion about the Identifier field. Also you can change the Collection Name for something else and a new suggestion for the Identifier field will appear.
  5. Select a Category.
  6. Submit the Form and you will be redirected to the just created Collection page with a successful creation alert.
  7. You can also try creating a collection standing in another sub collection and check that the Host Collection should be the correct one.
  8. Note that clicking on Add Data => New Collection from the header will always create a Collection with Root as owner collection.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Full size screenshot 👇
full_screen_size

Identifier suggestion functionality 👇
https://github.com/user-attachments/assets/8d8cee29-81f2-4e9a-b6f3-8549de4d46ba

Is there a release notes update needed for this change?:
N/A

Additional documentation:
N/A

@g-saracca g-saracca added UI Tasks related to the user interface (UI) or frontend development integration Tasks involving the connection and interaction of UI features with the Dataverse API Size: 3 A percentage of a sprint. 2.1 hours. and removed SPA: Collection Page labels Jul 15, 2024
@coveralls
Copy link

coveralls commented Jul 15, 2024

Coverage Status

coverage: 97.798% (+0.1%) from 97.682%
when pulling 60a9260 on feature/319-new-collection-page
into 91b2db6 on develop.

@ekraffmiller ekraffmiller self-assigned this Jul 18, 2024
@g-saracca
Copy link
Contributor Author

@ekraffmiller I have updated the changes from the style guide on the README

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GermanSaracca , it looks good! I just have some minor comments & questions

@g-saracca
Copy link
Contributor Author

@ekraffmiller all changes applied and I have also made an small change about the create collection URL.

Before:
/collections/create/:ownerCollectionId => /collections/create/root

After:
/collections/:ownerCollectionId/create => /collections/root/create

@g-saracca g-saracca assigned ekraffmiller and unassigned g-saracca Jul 19, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved!

@ekraffmiller ekraffmiller removed their assignment Jul 19, 2024
@GPortas GPortas self-assigned this Jul 24, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great! and the new feature for identifier suggestion is awesome.

createcollection.mov

@GPortas GPortas merged commit 6bc2261 into develop Jul 24, 2024
16 of 20 checks passed
@GPortas GPortas deleted the feature/319-new-collection-page branch July 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI Re-arch GREI re-architecture-related integration Tasks involving the connection and interaction of UI features with the Dataverse API Size: 3 A percentage of a sprint. 2.1 hours. SPA: New Collection Page UI Tasks related to the user interface (UI) or frontend development
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

"New Collection" Page
4 participants