-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/319 new collection page #433
Conversation
…d correspondent props
@ekraffmiller I have updated the changes from the style guide on the README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GermanSaracca , it looks good! I just have some minor comments & questions
src/sections/new-collection/collection-form/browse-search-facets-section/index.tsx
Outdated
Show resolved
Hide resolved
src/sections/new-collection/collection-form/useSubmitCollection.ts
Outdated
Show resolved
Hide resolved
@ekraffmiller all changes applied and I have also made an small change about the create collection URL. Before: After: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great! and the new feature for identifier suggestion is awesome.
What this PR does / why we need it:
Adds section/page to create a new collection and integrates with the js-dataverse use case.
Which issue(s) this PR closes:
Closes #319
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the New Collection page
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Full size screenshot 👇
Identifier suggestion functionality 👇
https://github.com/user-attachments/assets/8d8cee29-81f2-4e9a-b6f3-8549de4d46ba
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A