Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

407 create dataset prefill #414

Merged
merged 16 commits into from
Jun 17, 2024
Merged

407 create dataset prefill #414

merged 16 commits into from
Jun 17, 2024

Conversation

ekraffmiller
Copy link
Contributor

What this PR does / why we need it:
Fills Create Dataset form with info from the currently logged in user

Which issue(s) this PR closes:

Closes #407

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Jun 3, 2024

Coverage Status

coverage: 97.861% (+0.009%) from 97.852%
when pulling 5393f8f on 407-create-dataset-prefill
into 0e12edc on develop.

Base automatically changed from fix/393-match-api-email-validation2 to develop June 6, 2024 18:56
@ekraffmiller ekraffmiller marked this pull request as ready for review June 11, 2024 14:25
@ekraffmiller ekraffmiller added the GREI Re-arch GREI re-architecture-related label Jun 11, 2024
@g-saracca g-saracca self-assigned this Jun 12, 2024
@g-saracca g-saracca added SPA: Create Dataset Form Size: 3 A percentage of a sprint. 2.1 hours. labels Jun 12, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave a few small observations

@g-saracca g-saracca assigned ekraffmiller and unassigned g-saracca Jun 12, 2024
@ekraffmiller
Copy link
Contributor Author

Thanks @GermanSaracca, I made the changes you suggested.

Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the requested changes, approved!

@g-saracca g-saracca removed their assignment Jun 13, 2024
@GPortas GPortas self-assigned this Jun 14, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screenshot 2024-06-17 at 10 06 55

@GPortas GPortas merged commit fa7497a into develop Jun 17, 2024
20 checks passed
@GPortas GPortas deleted the 407-create-dataset-prefill branch June 17, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI Re-arch GREI re-architecture-related Size: 3 A percentage of a sprint. 2.1 hours. SPA: Create Dataset Form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Dataset Page - pre fill input fields to match JSF behavior
4 participants