-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PR triggers to github action workflows #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add this functionality also for the test workflow?
yes, thanks for catching that! I didn't add it to the deploy workflows however, since I thought that could skipped (and they are only triggered manually) |
add PR triggers to github action workflows
What this PR does / why we need it:
These are updates to our github actions to trigger test workflows when a PR is opened. The PR triggers will not run automatically for new external contributors - to run them we can start them manually in the PR.
Which issue(s) this PR closes:
Closes #398
Special notes for your reviewer:
I mislabeled the branch - it should be 398-pr-workflow-trigger, not 400
Suggestions on how to test this:
To recreate the use case, open a PR from a forked repository. For an current contributor, that should trigger the workflows, for a new contributor, a button in the "Conversations" tab of the PR should contain a button to manually trigger the workflows.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation: