Feature/340 collection host input #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm' into feature/340-collection-host-input
pdurbin
reviewed
May 20, 2024
g-saracca
added
pm.GREI-d-2.7.1
g-saracca
requested changes
May 20, 2024
There was a problem hiding this comment.
@ekraffmiller Looks great, just a few comments.
@pdurbin thanks for that catch!
src/sections/create-dataset/HostCollectionForm/HostCollectionForm.tsx
Outdated
Show resolved
Hide resolved
src/sections/create-dataset/HostCollectionForm/HostCollectionForm.tsx
Outdated
Show resolved
Hide resolved
src/sections/create-dataset/HostCollectionForm/HostCollectionForm.tsx
Outdated
Show resolved
Hide resolved
Base automatically changed from
feature/376-add-dynamic-field-types-to-create-dataset-form
to
develop
May 20, 2024 14:24
g-saracca
requested changes
May 21, 2024
| @@ -42,15 +45,20 @@ export function CreateDataset({ | |||
|
|
|||
| return ( | |||
| <article> | |||
| <NotImplementedModal show={isModalOpen} handleClose={hideModal} /> | |||
There was a problem hiding this comment.
Should live outside the article element, you can use a react fragment like this:
return (
<>
<article>
.....
</article>
<NotImplementedModal show={isModalOpen} handleClose={hideModal} />
<>
)
|
@GermanSaracca I made the changes you suggested, thank you |
g-saracca
approved these changes
May 21, 2024
GPortas
approved these changes
May 22, 2024
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
Feature/340 collection host input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a read only input field for the host collection in Create Dataset Page
Which issue(s) this PR closes:
Closes #340
Special notes for your reviewer:
Suggestions on how to test this:
Create a new collection then navigate to the collection page. From the collection page, select the "Add Dataset" dropdown. On the Create Dataset page, the Host Collection input should be prefilled with the alias of the new collection.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
no
Additional documentation:
none