-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/294 clear test datasets #360
Conversation
… sync with database during destroyAll()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're also creating datasets in the FileJSDataverseRepository.spec.ts
and Collection.spec.tsx
files. We should include the destroyAll
method there as well.
Additionally, since we're now destroying all datasets at the beginning of each test, we should consider removing all calls to the destroyAll
method within the individual tests. Such as in cy.wrap(DatasetHelper.destroyAll().then(() => DatasetHelper.createWithTitle(title)))
…l() from individual tests
thanks @MellyGray, I made the changes you suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @ekraffmiller , 2 suites of tests are failing, I attach screenshots. |
I unassign me from possible local environment problems to test this issue. Looks like a timing issue on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekraffmiller Can you please resolve the merge conflicts?
Feature/294 clear test datasets
What this PR does / why we need it:
Deletes test datasets before e2e tests, so that destroyAll() doesn't fail when trying to delete too many tests at once.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Run the e2e tests, check that test datasets have been deleted after the tests run. Check that "gets the total dataset count" test in DatasetJSDataverseRepository.spec.ts runs without errors
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
Additional documentation: