-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
295 - Display real dataset version information in the File Page #328
295 - Display real dataset version information in the File Page #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GPortas, I have updated the download URL, thank you. However, regarding the date, I believe we all agreed some time ago to use the local standard for dates in the UI instead of the international ISO format. Therefore, in your case, you're seeing the Spanish standard date format, which will differ for US users. However, even for US users, it will not match the JSF format, because we are now using the local format instead of the international ISO format. The same thing is happening in any SPA date |
@MellyGray Can you please resolve the conflicts? |
…into feature/295-display-real-dataset-version-information-in-the-file-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…t-version-information-in-the-file-page 295 - Display real dataset version information in the File Page
What this PR does / why we need it:
This PR adds the integration with js-dataverse to get the dataset version information from the getFile use case to display the data in the SPA File Page
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the development environment
npm I
cd packages/design-system && npm run build
cd ../../
.env
file such as the .env.example, with theVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
variablecd dev-env
./run-env.sh unstable
Step 2: Test breadcrumbs
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: