Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

295 - Display real dataset version information in the File Page #328

Conversation

MellyGray
Copy link
Contributor

What this PR does / why we need it:

This PR adds the integration with js-dataverse to get the dataset version information from the getFile use case to display the data in the SPA File Page

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Step 1: Run the development environment

  1. Run npm I
  2. cd packages/design-system && npm run build
  3. cd ../../
  4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
  5. cd dev-env
  6. ./run-env.sh unstable
  7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test breadcrumbs

  1. Go to http://localhost:8000
  2. Login as admin using username: dataverseAdmin and password: admin1
  3. Create a new Dataset
  4. Upload a file to the dataset
  5. Go to http://localhost:8000/spa and select your dataset in the list
  6. From the list of files in the Dataset page select your file to go to the File page
  7. In the File Page check that the dataset version information such as the version labels and dataset citation matches the real dataset version information

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@MellyGray MellyGray added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: File Page labels Feb 28, 2024
@MellyGray MellyGray marked this pull request as ready for review February 28, 2024 22:01
@MellyGray MellyGray added the integration Tasks involving the connection and interaction of UI features with the Dataverse API label Feb 28, 2024
@coveralls
Copy link

coveralls commented Feb 28, 2024

Coverage Status

coverage: 97.179% (+0.002%) from 97.177%
when pulling 13b10e4 on feature/295-display-real-dataset-version-information-in-the-file-page
into c0beef9 on develop.

@GPortas GPortas self-assigned this Feb 29, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

Here I share a couple of UI details that should be fixed to match the JSF version:

spa

Here is the JSF version:

jsf

@GPortas GPortas assigned MellyGray and unassigned GPortas Feb 29, 2024
@MellyGray
Copy link
Contributor Author

Looks good overall!

Here I share a couple of UI details that should be fixed to match the JSF version:

@GPortas, I have updated the download URL, thank you.

However, regarding the date, I believe we all agreed some time ago to use the local standard for dates in the UI instead of the international ISO format. Therefore, in your case, you're seeing the Spanish standard date format, which will differ for US users. However, even for US users, it will not match the JSF format, because we are now using the local format instead of the international ISO format. The same thing is happening in any SPA date

@MellyGray MellyGray assigned GPortas and unassigned MellyGray Feb 29, 2024
@GPortas
Copy link
Contributor

GPortas commented Feb 29, 2024

@MellyGray Can you please resolve the conflicts?

…into feature/295-display-real-dataset-version-information-in-the-file-page
@MellyGray MellyGray removed their assignment Feb 29, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GPortas GPortas merged commit 84fdf3b into develop Feb 29, 2024
10 of 14 checks passed
@GPortas GPortas deleted the feature/295-display-real-dataset-version-information-in-the-file-page branch February 29, 2024 14:35
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…t-version-information-in-the-file-page

295 - Display real dataset version information in the File Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Tasks involving the connection and interaction of UI features with the Dataverse API pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display real dataset version information in the File Page
3 participants