-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
305 update chromatic configurations #325
Conversation
moving from forked repository for review
@ekraffmiller - Chromatic works as-intended now, its a marvelous thing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finishing file review and requesting changes
Hi @M27Mangan, I merged the latest from develop, and you can see that several snapshots have changed now...I think that's because the new collection stories changed the order in which faker data was generated. I experimented with setting the faker seed in every .stories file to avoid this, but didn't have much luck. So this is a compromise, and sometimes the data will change. I think if we want to pursue it more, we could create another issue, let me know what you think. |
👍 Approved! |
Hi @ekraffmiller, have you resolved the issue? I reviewed the latest build and noticed some changes in the snapshots |
@MellyGray I updated the code to remove the loading delay, because I wanted to make sure all the calls to faker were made in a deterministic way. This removed most of the differences, but there are still some differences in FileInfoCell that I need to figure out. So I'm going to put the issue back to In Progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The Chromatic builds seem to be fixed!
…ions 305 update chromatic configurations
What this PR does / why we need it:
The Chromatic snapshots are hard to review because they show changes that are due to faker randomized data, and some stories have built in loading delays. The changes make the faker data more reproducible, and add a delay before taking some snapshots.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
To reproduce the behavior of a Chromatic build, add a
.env
file to the root directory of the project, with this setting:STORYBOOK_CHROMATIC_BUILD=true
In a local build, open Storybook and go to a story. If you refresh the browser multiple times, the faker data should stay the same between refreshes.
The link to the Chromatic build is in the github action. You can go to the build, and approve the current changes (there have been ui changes since the last approval), and check that the faker data doesn't change between builds.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: