Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

264 - Add the AccessFileMenu to File Page #286

Conversation

MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Jan 24, 2024

What this PR does / why we need it:

This PR adds the AccessFileMenu to the File Page. Since the menu component already existed and was being used in the Files Table from the Dataset Page in its button icon form, I refactored the necessary components to rehuse the component in the File Page.

To refactor the AccessFileMenu component I first needed to extract the File Metadata from the File model. That's why this branch parent is refactor/263-extract-file-metadata

Which issue(s) this PR closes:

Special notes for your reviewer:

Take into account that the button already existed in its icon button shape in the Dataset Page:
Captura de pantalla 2024-01-24 a las 16 48 52

Suggestions on how to test this:

  1. Install the necessary dependencies using npm install.
  2. Build the design system with cd packages/design-system && npm run build.
  3. Navigate back to the root directory with cd ../../.
  4. Start Storybook with npm run storybook.
  5. Visit the File Page in the Storybook and check that the Access File Menu looks as expected
  6. For detailed menu stories visit AccessFileMenu stories
  7. To ensure that the refactor didn't affect the button in the Files Table, which is the same button but in its button icon shape, take a look at the Access File Menu in the Dataset Page story

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Captura de pantalla 2023-12-14 a las 11 41 12

Is there a release notes update needed for this change?:

No

Additional documentation:

@MellyGray MellyGray linked an issue Jan 24, 2024 that may be closed by this pull request
@MellyGray MellyGray changed the base branch from develop to refactor/263-extract-file-metadata January 24, 2024 15:49
@coveralls
Copy link

coveralls commented Jan 24, 2024

Coverage Status

coverage: 97.595% (-0.3%) from 97.871%
when pulling 7a1ce85 on feature/264-add-the-accessfile-button
into e80a75f on refactor/263-extract-file-metadata.

@MellyGray MellyGray marked this pull request as ready for review January 24, 2024 16:04
@MellyGray MellyGray added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows UI Tasks related to the user interface (UI) or frontend development labels Jan 24, 2024
@M27Mangan M27Mangan self-requested a review January 29, 2024 16:39
@M27Mangan M27Mangan self-assigned this Jan 29, 2024
Copy link

@M27Mangan M27Mangan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@M27Mangan M27Mangan removed their assignment Jan 29, 2024
@ekraffmiller ekraffmiller self-assigned this Jan 29, 2024
@ekraffmiller
Copy link
Contributor

Looks good! In testing the Embargo option, I found an unrelated bug, added here: #292.

@ekraffmiller ekraffmiller merged commit 16fad5f into refactor/263-extract-file-metadata Jan 29, 2024
17 of 20 checks passed
@MellyGray MellyGray deleted the feature/264-add-the-accessfile-button branch February 1, 2024 14:13
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…button

264 - Add the AccessFileMenu to File Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the AccessFile button to the File Page
4 participants