-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
264 - Add the AccessFileMenu to File Page #286
Merged
ekraffmiller
merged 11 commits into
refactor/263-extract-file-metadata
from
feature/264-add-the-accessfile-button
Jan 29, 2024
Merged
264 - Add the AccessFileMenu to File Page #286
ekraffmiller
merged 11 commits into
refactor/263-extract-file-metadata
from
feature/264-add-the-accessfile-button
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellyGray
changed the base branch from
develop
to
refactor/263-extract-file-metadata
January 24, 2024 15:49
MellyGray
added
Size: 3
A percentage of a sprint. 2.1 hours.
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
UI
Tasks related to the user interface (UI) or frontend development
labels
Jan 24, 2024
M27Mangan
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Looks good! In testing the Embargo option, I found an unrelated bug, added here: #292. |
ekraffmiller
merged commit Jan 29, 2024
16fad5f
into
refactor/263-extract-file-metadata
17 of 20 checks passed
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…button 264 - Add the AccessFileMenu to File Page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Size: 3
A percentage of a sprint. 2.1 hours.
UI
Tasks related to the user interface (UI) or frontend development
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the AccessFileMenu to the File Page. Since the menu component already existed and was being used in the Files Table from the Dataset Page in its button icon form, I refactored the necessary components to rehuse the component in the File Page.
To refactor the AccessFileMenu component I first needed to extract the File Metadata from the File model. That's why this branch parent is refactor/263-extract-file-metadata
Which issue(s) this PR closes:
Special notes for your reviewer:
Take into account that the button already existed in its icon button shape in the Dataset Page:
Suggestions on how to test this:
npm install
.cd packages/design-system && npm run build
.cd ../../
.npm run storybook
.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
No
Additional documentation: