-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/250 dataset list integration #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Home is working in localhost! 👏
I left a few comments about the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks very good! It is really nice to see the home page working with real data. Nice work @ekraffmiller @MellyGray !
I have done different tests, which I share below with videos and the steps to reproduce.
I'm using emojis (🚨 and ✅) to explain if the behavior is working as expected or if revision is required.
TEST 1 - Create first dataset from empty installation
creatingvideo.mov
Steps:
- Dataverse is empty, so I log in via JSF to create a data set.
- I create a test dataset through JSF
- I navigate to the JSF home page to see how the created dataset card is displayed in the list.
- ✅ I navigate to the SPA home page to verify that the new dataset is displayed in the list with the same appearance as in JSF.
- 🚨 I click the dataset in the list and navigate to the dataset page. I see that when navigating, instead of directly opening the dataset page, it goes through an intermediate page where a text "loading" appears (very quickly, but noticeable). See the following screenshot:
- ✅ The dataset page correctly displays the requested dataset
TEST 2 - Publish the dataset to verify that information is updated in the home page list
- I publish the dataset through JSF
- ✅ I refresh the home page in the SPA to verify the dataset info is updated
publishingvideo.mov
TEST 3 - Pagination: verify that pages are displayed correctly and pagination controllers work as expected
- I created more than 10 datasets via JSF in order to have two result pages
- ✅ In the SPA, each page is correctly rendered with its associated elements
- ✅ Pagination controllers work as expected
paginationtest1.mov
TEST 4 - Pagination: Back button and URL page query param
🚨
In JSF, a query parameter is added to the URL to indicate the results page you are on. I think we should continue to support this. It is useful for scenarios like the following:
-
When you have navigated to a new result page, by clicking on the browser's back button you navigate to the previously selected page.
-
With the query param you are also able to share a URL that leads directly to a particular page on the home page.
You can see in the following video how, by not adding the query parameter, the back button navigates to the page before reaching the home page.
paginationtest2.mov
As discussed at standup, I created new issues based on QA of this PR. |
…ration Features/250 dataset list integration
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: