Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Select multiple component for the design system #355

Closed
g-saracca opened this issue Mar 27, 2024 · 2 comments · Fixed by #385
Closed

Create Select multiple component for the design system #355

g-saracca opened this issue Mar 27, 2024 · 2 comments · Fixed by #385
Assignees
Labels
D: Design System Deliverable: Design System pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 50 A percentage of a sprint. 35 hours. UI Tasks related to the user interface (UI) or frontend development

Comments

@g-saracca
Copy link
Contributor

g-saracca commented Mar 27, 2024

We should create a multiple select with search as well as the one that exists in JSF for multiple vocabulary fields.
The scope of this ticket should aim to just create the component within the design system and make it look as similar as possible to the rest of the components.

Notes:

  • We could use a very popular and widely used library called React-Select

Update
Not using react-select library now, see comment

Create the component from scratch, without external libraries and make it according to our needs as in the JSF version
Screenshot 2024-04-19 at 09 17 30

@g-saracca g-saracca added Size: 10 A percentage of a sprint. 7 hours. D: Design System Deliverable: Design System pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows UI Tasks related to the user interface (UI) or frontend development labels Mar 27, 2024
@g-saracca g-saracca changed the title Select multiple component for the design system Create Select multiple component for the design system Mar 27, 2024
@GPortas GPortas moved this to SPRINT READY in IQSS Dataverse Project Mar 27, 2024
@GPortas GPortas moved this from SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Mar 27, 2024
@g-saracca g-saracca moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Apr 17, 2024
@g-saracca g-saracca self-assigned this Apr 17, 2024
@g-saracca
Copy link
Contributor Author

I found out that the react-select library I was planning to use is no longer maintained 6 months ago and is too heavy, it would increase almost 70% the size of the design system bundle.
In my opinion, the best idea now is to create the component from scratch, without external libraries and make it according to our needs, but it will need more time to be done.
I'm moving this to the backlog until it takes priority over other things as this is a nice to have.

@g-saracca g-saracca removed their assignment Apr 19, 2024
@g-saracca g-saracca added Size: 80 A percentage of a sprint. 56 hours. and removed Size: 10 A percentage of a sprint. 7 hours. labels Apr 19, 2024
@g-saracca g-saracca moved this to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Apr 22, 2024
@g-saracca
Copy link
Contributor Author

Update:
We decided with the team to focus on this component now, as it is necessary for the creation of a dataset. We moved it back to this Sprint, I will start working on it today 🚀.

@g-saracca g-saracca moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Apr 22, 2024
@g-saracca g-saracca self-assigned this Apr 22, 2024
@cmbz cmbz added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) and removed Size: 80 A percentage of a sprint. 56 hours. labels Apr 25, 2024
@scolapasta scolapasta added Size: 50 A percentage of a sprint. 35 hours. and removed Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: Design System Deliverable: Design System pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 50 A percentage of a sprint. 35 hours. UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants