Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds UpdateCollection use case #204

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Adds UpdateCollection use case #204

merged 6 commits into from
Nov 6, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Oct 22, 2024 •
edited
Loading

What this PR does / why we need it:

Implements UpdateCollection use case.

Which issue(s) this PR closes:

Related Dataverse PRs:

Environment variables should be changed before moving this PR to Ready For QA

Special notes for your reviewer:

None

Suggestions on how to test this:

Visual inspection of the code and tests on GitHub actions.

Is there a release notes update needed for this change?:

N/A

Additional documentation:

No

@GPortas GPortas marked this pull request as ready for review October 23, 2024 10:01
@GPortas GPortas added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q4.3 Edit Collection Page Waiting labels Oct 23, 2024
@GPortas
Copy link
Contributor Author

GPortas commented Oct 23, 2024

Waiting for IQSS/dataverse#10925 to be ready

@GPortas GPortas self-assigned this Oct 23, 2024
@cmbz cmbz added FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) labels Oct 23, 2024
@GPortas GPortas removed the Waiting label Oct 24, 2024
@GPortas GPortas removed their assignment Oct 24, 2024
@g-saracca g-saracca self-assigned this Oct 25, 2024
@g-saracca g-saracca removed their assignment Oct 25, 2024
@g-saracca
Copy link
Contributor

@ofahimIQSS we should maybe wait to test this until the related dataverse repo PR is done.
Once that PR is merged, we should change .env variables back to using unstable docker image.

@cmbz cmbz mentioned this pull request Oct 28, 2024
Open
@ofahimIQSS ofahimIQSS self-assigned this Nov 1, 2024
@ofahimIQSS ofahimIQSS removed the Waiting label Nov 1, 2024
@ofahimIQSS
Copy link
Contributor

It looks like the job @github-actions
deploy_pr / publish-gpr (pull_request) is failing - https://github.com/IQSS/dataverse-client-javascript/actions/runs/11477537944/job/32481330196?pr=204

@ofahimIQSS
Copy link
Contributor

Reviewed - Merging PR

@ofahimIQSS ofahimIQSS merged commit 67d3b0e into develop Nov 6, 2024
4 of 5 checks passed
@ofahimIQSS ofahimIQSS deleted the 200-update-collection branch November 6, 2024 15:50
@ofahimIQSS ofahimIQSS removed their assignment Nov 6, 2024
@g-saracca g-saracca mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-saracca g-saracca g-saracca approved these changes

Assignees
No one assigned
Labels
FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q4.3 Edit Collection Page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Collection use case [JS-Dataverse]
4 participants
@GPortas @g-saracca @ofahimIQSS @cmbz