Pass all files through gofmt
#1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, this commit records the result of running ```sh gofmt -w . ``` This brings the code into alignment with Go's established style.
Pass all files through `gofmt`
…eader This will facilitate holding the contents in memory without large, extraneous allocations. (As mentioned elsewhere, the memfd_create(2) and mmap(2) tricks had issues.)
Change the type of FileReader.Handler from *os.File to *bytes.Reader
|
We are reviewing this and will get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if you accept contributions, but we've needed to fork this for some internal reasons. This branch is only stylistic: it records the result of running
gofmt -w .This brings the code into alignment with Go's established style.
(For our fork, we'll want to map things into memory. Tricks with memfd_create(2) and mmap(2) to create a suitable memory-backed "file" for use with the IPQS reader work, but this leads to issues around reported memory use (and so with cgroups v2). I don't want to try and circumvent those issues. It'll be easier for me to change things to hold a pointer to a buffer and to avoid the tricks.)