VE-221 Migrate deprecated APIs #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4manjesh
changed the title
|
The app layout changes looks good @m4manjesh |
|
Sidebar item text not visible in darkmode |
nikitharani
requested changes
Dec 8, 2024
| /> | ||
| </Grid> | ||
| </Grid> | ||
| )} | ||
| {status === "success" && ( | ||
| <Alert severity="success" style={{ marginBottom: 16 }}> | ||
| <Alert severity="success" sx={{ marginBottom: 1 }}> |
There was a problem hiding this comment.
is marginBottom: 1 intentional?
There was a problem hiding this comment.
In the MUI spacing convention 1 unit is 8px, so the correct replacement would be sx={{ mb: 2 }}
src/Sidebar/Sidebar.tsx
Outdated
| alignItems: "center", | ||
| display: "flex", | ||
| justifyContent: "space-between", | ||
| p: theme => theme.spacing(2) |
| @@ -159,7 +185,7 @@ function VirtoAppHeader({ | |||
| onClose={() => setAppOpen(false)} | |||
| sx={theme => ({ | |||
| "& .MuiDrawer-paper": { | |||
| height: `calc(100% - ${theme.mixins.toolbar.minHeight}px)`, | |||
| height: `calc(100vh - ${theme.mixins.toolbar.minHeight}px) `, | |||
mattcorner
reviewed
Dec 9, 2024
Good catch. Seems like this is working fine with |
nikitharani
requested changes
Dec 10, 2024
| /> | ||
| </Grid> | ||
| </Grid> | ||
| )} | ||
| {status === "success" && ( | ||
| <Alert severity="success" style={{ marginBottom: 16 }}> | ||
| <Alert severity="success" sx={{ mb: 1 }}> |
There was a problem hiding this comment.
This should be mb:2 to match the marginBottom: 16, as mb:1 equals 8px.
nikitharani
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes VE-221
Changes
During the RUI migration to MUI v6 here, we noticed it is good to handle deprecations now before they become breaking changes. This PR focuses on migrating recently deprecated APIs to stay up-to-date and improve the developer experience.
A brief description of what this pull request solves / introduces.
Many system props such as
mt,bgColorand more are deprecated in Box, Typography, Link, Grid, and Stack components. So here we are moving the most of the of the system props tosxprops. See below exampleHiddencomponent was already deprecated. Remove it and useuseMediaQueryto achieve the same behaviour as followsIn ThemeProvider.tsx i have added
mixins.toolbar.minHeight to 64to fixAppLauncheroveroverlapping issue withAppHeaderin VIRTO apps. Also changed using custom64pxinVirtoAppLayoutandAppLayoutto calculateheightandtop, instead of usingtheme.mixins.toolbar.minHeight.Before
After
componentsandcomponentPropsare deprecated and eventually removed. Using standardizedslotsandslotPropsinsteadDependencies
This needs to wait to merge until this PR gets merged
UI/UX
There are some small UI changes related to
AppLaunchertop spacing as mentioned above. It would be good to get reviewed by you @Sowbhagya-ipg.Testing notes
Most of the components touched and most of the changes are identical in this PR. But still, make sure all stories are still working the same as before. Check that the changes i made in
VirtoAppLayoutandAppLayoutdidn't break the behaviour we have.Author checklist
Before I request a review:
I have included appropriate tests.I have populated the deploy-preview with relevant test data.