Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImageUploader container's wrong spelled CSS property #870

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix ImageUploader container's wrong spelled CSS property #870

merged 1 commit into from
May 17, 2024

Conversation

m4manjesh
Copy link
Contributor

@m4manjesh m4manjesh commented May 17, 2024 •
edited
Loading

Closes TD-2765

Changes

  • pointerEvenets to pointerEvents to restrict user to click on seleced image to upload new one

Dependencies

UI/UX

Testing notes

  • Check user is able to upload new image only after deleting uploaded one by clicking on delete button

Author checklist before assigning a reviewer

  • Reviewed my own code-diff.
  • Branch has been run in docker.
  • PR assigned to me or an appropriate delegate.
  • Relevant labels added to the PR.
  • Appropriate tests have been added.
  • Lint and test workflows pass.

@m4manjesh m4manjesh added the bug Something isn't working label May 17, 2024
@m4manjesh m4manjesh self-assigned this May 17, 2024
@m4manjesh m4manjesh changed the base branch from main to release/v7.6.4 May 17, 2024 09:39
@m4manjesh m4manjesh mentioned this pull request May 17, 2024
Closed
7 tasks
@syedsalehinipg syedsalehinipg self-requested a review May 17, 2024 09:43
@m4manjesh m4manjesh requested review from syedsalehinipg and removed request for syedsalehinipg May 17, 2024 09:44
syedsalehinipg
syedsalehinipg approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@syedsalehinipg syedsalehinipg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@m4manjesh m4manjesh merged commit a7650a0 into release/v7.6.4 May 17, 2024
1 check passed
@m4manjesh m4manjesh deleted the bug/imageuploader-wrong-css-property branch May 17, 2024 10:06
@m4manjesh m4manjesh mentioned this pull request May 24, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedsalehinipg syedsalehinipg syedsalehinipg approved these changes

Assignees

@m4manjesh m4manjesh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4manjesh @syedsalehinipg