-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future/pnpm #811
Future/pnpm #811
Conversation
41696de
to
b6b7eba
Compare
@mattcorner would you like me to have a bash with this? |
Couple more bits to wrap my head around, but i'll send it you way when ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's just have a quick chat tomorrow before merging to align on couple of things.
I think we're good to go with this now @mattcorner? I assume your prerelease worked as expected? |
Changes
Changes from using
npm
as a package manager topnpm
.Benefits:
More detail on Github Action Caching:
The cache key is
${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
.Hence as long as no pnpm-lock.yaml file have not changed, then we will hit the cache.
Dependencies
UI/UX
Testing notes
All developers will need to install
pnpm
. There are many methods to doing so: https://pnpm.io/installationAuthor checklist before assigning a reviewer
Appropriate tests have been added.