UserAvatar font-size consistency #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcorner
force-pushed
the
bug/avatar-font-size
branch
from
4c28e5c to
0a40d4c
Compare
|
@VictorCLLucas you VehicleSelect tests are still flaky. They've failed on this branch despite no related code changing. |
I did not see this behavior when I raised the PR. Does it pass when you retry? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While reviewing some recent VIRTO.ID migration work, it was noted that the UserAvatar component used in the UserMenu, and the UserAvatar component used elsewhere had different font sizes. I confirmed with @Sowbhagya-ipg that she would like them to be consistent.
Previously the
UserMenuwas creating its own internalUserAvatarcomponent. I have switched this over to use our ownUserAvatarcomponent. This component now accepts ansxprop so thatUserMenucan apply the additional styles that it needs.UI/UX
UserMenu
UserAvatar
Testing notes
You can test UserAvatar and UserMenu in storybook using lightmode and dark mode.
I have also added tests for both components to check font-size.
Author checklist before assigning a reviewer
Lint and test workflows pass.Passing on Windows and Linux. Unrelated tests failing on MacOS. I don't think they should stop this being merged.