TD-2946 Scene Freezes On Deleting Scenario #1012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcorner
reviewed
Dec 20, 2024
| @@ -152,7 +152,7 @@ describe("useConfirm", () => { | |||
| fireEvent.click(getByText("Delete")); | |||
| expect(queryByText("Remove this item?")).toBeTruthy(); | |||
| fireEvent.click(getByText("Yes")); | |||
| expect(queryByText("Remove this item?")).toBeTruthy(); | |||
| expect(queryByText("Remove this item?")).toBeFalsy(); | |||
There was a problem hiding this comment.
I don't think this test is valid any more. Suggest removing it. It is checking that the dialog is still in the DOM even when the dialog is closed which is no longer the case.
…s://github.com/IPG-Automotive-UK/react-ui into bug/TD-2946-scene-freezes-on-deleting-scenario
mattcorner
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to TD-2946
Changes
ConfirmationDialog.tsxis now conditionally rendered based on the open prop.Preview
Testing notes
Author checklist
Before I request a review:
I have included appropriate tests.I have populated the deploy-preview with relevant test data.I have tagged a UI/UX designer for review if this PR includes UI/UX changes.