952 include configuration for git mode in libms #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prasadtalasila I have added modules now. Was this what you meant? |
|
Module separation seems ok. Please use |
…ps://github.com/INTO-CPS-Association/DTaaS into 952-include-configuration-for-git-mode-in-libms
There was a problem hiding this comment.
This goes into useFactory method inside files.module.ts
|
@prasadtalasila Can you have a look again please? |
|
@nichlaes please rebase to |
|
@prasadtalasila should be good, when I merge, it says it's up to date |
…n-for-git-mode-in-libms
|
@prasadtalasila The changes have been made. I changed one other thing. The fileService factory, now gets a map of IFileServices instead. So in the future, if we add another, it would be easier. |
|
Code Climate has analyzed commit c7109b0 and detected 0 issues on this pull request. View more on Code Climate. |
prasadtalasila
deleted the
952-include-configuration-for-git-mode-in-libms
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.