Adds integration tests to client website #863
Conversation
|
@prasadtalasila Is this the intended interaction between the Recording.2024-07-08.190052.mp4 |
|
@atomicgamedeveloper yes, that is correct. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Ok, thank you. I will capture this in a test. Also I will see to removing the no-plusplus Error and cut down the file length to below 250. |
Thanks |
…-integration-test-client
| <Workbench /> | ||
| </MemoryRouter> | ||
| ); | ||
| beforeEach(() => { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| collapseWhitespace: false, | ||
| }); | ||
|
|
||
| beforeEach(() => { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| }); | ||
|
|
||
| it('changes iframe src according to the the selected tab', () => { | ||
| for (let i = 0; i < tabs.length; i += 1) { |
There was a problem hiding this comment.
Please name the variable more appropriately
| import * as React from 'react'; | ||
| import { | ||
| getDefaultNormalizer, | ||
| fireEvent, |
There was a problem hiding this comment.
You mentioned about user-event. Is it possible to use it?
There was a problem hiding this comment.
Unfortunately not easily due to awaits in loops being disallowed by the ESLint rules, but I will give it another try.
|
|
||
| it('selects the first scope tab when you select an assetType tab', () => { | ||
| // i is 1 as the first tab is already selected so clicking on it will not have an effect on the subtabs | ||
| for (let i = 1; i < assetType.length; i += 1) { |
There was a problem hiding this comment.
Please use a better variable name here
| selected: isFirstAssetTypeTab, | ||
| }); | ||
| fireEvent.click(assetTypeTab); | ||
| for (let j = 0; j < scope.length; j += 1) { |
There was a problem hiding this comment.
please use a better variable name
|
@atomicgamedeveloper glad to see the improvements in test coverage. |
There was a problem hiding this comment.
@atomicgamedeveloper thanks for the PR updates. The tests on the following files can be improved.
----------------------------------|---------|----------|---------|---------|----------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------------------------------|---------|----------|---------|---------|----------------------
Title.tsx | 0 | 100 | 0 | 0 | 1-16
AccountTabData.tsx | 100 | 79.41 | 100 | 100 | 48-52,73
AuthProvider.tsx | 0 | 0 | 0 | 0 | 1-19
PrivateRoute.tsx | 83.33 | 73.33 | 100 | 83.33 | 22,28,30,41
Signin.tsx | 63.63 | 100 | 0 | 63.63 | 10-16
WaitAndNavigate.tsx | 30 | 0 | 0 | 31.57 | 9-29
src/util | 82.05 | 77.77 | 53.33 | 81.57 |
src/util/auth | 26.08 | 30 | 12.5 | 26.66 |
Authentication.ts | 37.5 | 60 | 16.66 | 37.5 | 26-49,54-58
useOidcConfig.ts | 0 | 0 | 0 | 0 | 1-44Please check the comments as well.
There was a problem hiding this comment.
since unitTests/__mocks__ are used in integration tests too, is there a benefit in moving them to ``test/` directory?
client/test/unitTests/jest.setup.ts
Outdated
There was a problem hiding this comment.
this is nice. Perhaps mocks placed in test/__mocks__ be imported like this`?
|
The |
It is not referenced anywhere in the project as far as I can tell from searching the codebase. |
|
@atomicgamedeveloper The PR looks ready to merge. Please make the following changes.
|
|
Code Climate has analyzed commit 0c78ccb and detected 0 issues on this pull request. View more on Code Climate. |
prasadtalasila
merged commit a335ae4
into
INTO-CPS-Association:feature/distributed-demo
prasadtalasila
changed the title
This PR relates to issue #826 about testing the Library page of the client.