-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor docker installation and docs #764
Refactor docker installation and docs #764
Conversation
prasadtalasila
commented
May 18, 2024
- Refactors docker files into deploy and developer parts
- Simplifies the localhost installation for docker compose
- Remove the shell script installation scripts
- Removes the redundant traefik config files ins servers/config
- Updates some of the docs
deploy/README.md
Outdated
[reactjs](https://krify.co/about-reactjs/), | ||
[nestjs](https://camunda.com/blog/2019/10/nestjs-tx-email/) | ||
1. Single user [localhost](./docker/LOCALHOST.md) | ||
2. Multi-user [web application](./docker/SERVER.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordered list item prefix
If you desire to use locally hosted gitlab instance, please see | ||
the [client docs](../docs/admin/client/auth.md). | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple consecutive blank lines
deploy/docker/LOCALHOST.md
Outdated
## Use | ||
|
||
The application will be accessible at: | ||
<http>_http://localhost_</http> from web browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bare URL used
deploy/docker/README.md
Outdated
There are two installation scenarios each with a dedicated set of instructions: | ||
|
||
1. Single user [localhost](./LOCALHOST.md) | ||
2. Multi-user [web application](./SERVER.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordered list item prefix
deploy/docker/SERVER.md
Outdated
## Use | ||
|
||
The application will be accessible at: | ||
<http>_http://foo.com_</http> from web browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bare URL used
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #764 +/- ##
=============================================================
+ Coverage 66.49% 91.66% +25.16%
=============================================================
Files 31 11 -20
Lines 394 84 -310
Branches 26 7 -19
=============================================================
- Hits 262 77 -185
+ Misses 117 0 -117
+ Partials 15 7 -8 see 34 files with indirect coverage changes
|
docs/admin/host.md
Outdated
|
||
## Perform the Installation | ||
The application will be accessible at: | ||
<http>_http://foo.com_</http> from web browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bare URL used
docs/admin/localhost.md
Outdated
## Use | ||
|
||
The application will be accessible at: | ||
<http>_http://localhost_</http> from web browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bare URL used
docker/README.md
Outdated
The Traefik forward-auth uses OAuth2 for protecting all routes to user workspaces. | ||
Use of docker images is handy for developers. It is suggested | ||
that developers build the required images locally on their computer and | ||
use them for development purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docker/README.md
Outdated
|
||
## Adding a new user | ||
Build and publish the docker images. This step is required only for | ||
the publication of images to Docker Hub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docker/README.md
Outdated
1. docker/.env | ||
please see [docker README](../deploy/docker/SERVER.md) for help | ||
with updating this config file) | ||
2. docker/conf.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordered list item prefix
|
||
1. The path examples given here are for Linux OS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
docker/README.md
Outdated
2. docker/conf.local | ||
please see [server docs](../docs/admin/servers/auth.md) for help | ||
with updating this config file) | ||
3. client/config/local.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordered list item prefix
docker/README.md
Outdated
3. client/config/local.js | ||
please see [client config](../docs/admin/client/CLIENT.md) for help | ||
with updating this config file) | ||
4. servers/lib/config/.env.default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordered list item prefix
docker/README.md
Outdated
|
||
Sign in to gitlab instance with the your account. | ||
The application will be accessible at: | ||
<http>_http://localhost_</http> from web browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bare URL used
8e50d31
to
55e37c1
Compare
|
||
!!! tip file pathnames | ||
|
||
1. The filepaths shown here follow Linux OS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
for client. The corresponding OAuth application | ||
details are: | ||
|
||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
<!-- prettier-ignore --> | ||
!!! tip file pathnames | ||
|
||
1. The filepaths shown here follow POSIX convention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
Code Climate has analyzed commit 5e26fbd and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
725e144
into
INTO-CPS-Association:feature/distributed-demo