Implements CLI options for runner and adds devContainer config #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runner-factory service.
The config is still hardcoded. WIP
The code works and all the tests pass. Integration with commander is still a WIP
TODO: Tests, validation against permitted commands,
error handling of config and file reading
The runner working directory is defined by the location of the runner.yaml config file given at the runtime.
AppController
AppController. Some integration tests on ValidationPipe are pending.
|
Code Climate has analyzed commit 53bfaaf and detected 0 issues on this pull request. View more on Code Climate. |
prasadtalasila
merged commit 5713969
into
INTO-CPS-Association:feature/distributed-demo
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
to create development environment. It is a good replacement
for the script/ folder.