Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner config with execution #614

Conversation

prasadtalasila
Copy link
Contributor

No description provided.

@@ -10,83 +9,77 @@ launched in two scenarios:

1. User launches this from commandline and let the utility
manage the lifecycle of one digital twin.
1. Execution infrastructure of Digital Twin as a Service (DTaaS)
2. Execution infrastructure of Digital Twin as a Service (DTaaS)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordered list item prefix

@codecov-commenter
Copy link

Codecov Report

Merging #614 (2950ee5) into feature/distributed-demo (375d3a9) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/distributed-demo     #614      +/-   ##
============================================================
+ Coverage                     93.33%   93.47%   +0.14%     
============================================================
  Files                             5        5              
  Lines                            45       46       +1     
  Branches                          3        3              
============================================================
+ Hits                             42       43       +1     
  Partials                          3        3              
Files Coverage Δ
servers/execution/runner/src/app.controller.ts 100.00% <100.00%> (ø)
...rvers/execution/runner/src/config/configuration.ts 100.00% <100.00%> (ø)
...s/execution/runner/src/lifecycleManager.service.ts 91.66% <100.00%> (+0.75%) ⬆️
Components Coverage Δ
Website ∅ <ø> (∅)
Lib Microservice ∅ <ø> (∅)

const body = {
name: 'configure',
};
supertest(app.getHttpServer())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@prasadtalasila prasadtalasila force-pushed the runner-config-with-execution branch from 4c0e3b5 to 7f41c00 Compare April 8, 2024 19:50

dt.changePhase(pastPhases[0]).then(([value]) => {
dt.changePhase(pastPhases[0].name).then(([value]) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

status.push(value);
});
dt.changePhase(pastPhases[1]).then(([value]) => {
dt.changePhase(pastPhases[1].name).then(([value]) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.


=== "Valid HTTP Request"

``` http-request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code block style


=== "HTTP Response - Valid Command"

``` http-response
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code block style


=== "HTTP Response - Inalid Command"

``` http-request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code block style


=== "Valid HTTP Request"

``` http-request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code block style


=== "HTTP Response - Valid Command"

``` http-response
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code block style


=== "HTTP Response - Inalid Command"

``` http-request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code block style

Copy link

codeclimate bot commented Apr 9, 2024

Code Climate has analyzed commit c6789a2 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 6

View more on Code Climate.

@prasadtalasila prasadtalasila merged commit 12e0427 into INTO-CPS-Association:feature/distributed-demo Apr 9, 2024
3 checks passed
@prasadtalasila prasadtalasila deleted the runner-config-with-execution branch April 9, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants