-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runner config with execution #614
Runner config with execution #614
Conversation
servers/execution/runner/README.md
Outdated
@@ -10,83 +9,77 @@ launched in two scenarios: | |||
|
|||
1. User launches this from commandline and let the utility | |||
manage the lifecycle of one digital twin. | |||
1. Execution infrastructure of Digital Twin as a Service (DTaaS) | |||
2. Execution infrastructure of Digital Twin as a Service (DTaaS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordered list item prefix
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #614 +/- ##
============================================================
+ Coverage 93.33% 93.47% +0.14%
============================================================
Files 5 5
Lines 45 46 +1
Branches 3 3
============================================================
+ Hits 42 43 +1
Partials 3 3
|
const body = { | ||
name: 'configure', | ||
}; | ||
supertest(app.getHttpServer()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
TODO: fix e2e tests, missing logs in API requests
4c0e3b5
to
7f41c00
Compare
|
||
dt.changePhase(pastPhases[0]).then(([value]) => { | ||
dt.changePhase(pastPhases[0].name).then(([value]) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
status.push(value); | ||
}); | ||
dt.changePhase(pastPhases[1]).then(([value]) => { | ||
dt.changePhase(pastPhases[1].name).then(([value]) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Adds /history route to runner API
|
||
=== "Valid HTTP Request" | ||
|
||
``` http-request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
|
||
=== "HTTP Response - Valid Command" | ||
|
||
``` http-response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
|
||
=== "HTTP Response - Inalid Command" | ||
|
||
``` http-request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
|
||
=== "Valid HTTP Request" | ||
|
||
``` http-request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
|
||
=== "HTTP Response - Valid Command" | ||
|
||
``` http-response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
|
||
=== "HTTP Response - Inalid Command" | ||
|
||
``` http-request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block style
Code Climate has analyzed commit c6789a2 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
12e0427
into
INTO-CPS-Association:feature/distributed-demo
No description provided.