fix: 🐛 issues green-code-initiative#228 green-code-initiative#233 gre…

…en-code-initiative#235 green-code-initiative#240
INTM-Group · Jan 18, 2024 · fc987b9 · fc987b9
1 parent c0a5237
commit fc987b9
Show file tree

Hide file tree

Showing 12 changed files with 4 additions and 220 deletions.
diff --git a/RULES.md b/RULES.md
@@ -70,12 +70,8 @@ This table lists rules proposed by the community but deprecated in ecoCode plugi
 
 | Rule key | Language            | Name                                               | Description                                                                                              | Invalidation                                                                                                                                                                                                                                                 |
 |----------|---------------------|----------------------------------------------------|----------------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| EC4      | Java                | Avoid using global variables                       | Global variables do not exist in Java.                                                                   | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/233)                                                                                                                                                                |
 | EC34     | Java / Python / PHP | Using try...catch...finally calls                  | Implementation is too simple (only detection of presence of "try" statement) AND replaced by `EC35` rule | Github discussion with measures : [general/java](https://github.com/green-code-initiative/ecoCode/pull/128) / [python](https://github.com/green-code-initiative/ecoCode-python/pull/6) / [php](https://github.com/green-code-initiative/ecoCode-php/pull/10) |
-| EC53     | Java                | Using arrays in foreach loops                      | No good arguments and not enough green measures.                                                         | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/240)                                                                                                                                                                |
-| EC63     | Java                | Unnecessarily assigning values to variables        | There are already 3 native SonarQube rules for Java.                                                     | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/pull/258)                                                                                                                                                                  |
 | EC66     | Python              | Use single quote (') instead of quotation mark (") | Finally, not applicable for Python                                                                       | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode-python/issues/4)                                                                                                                                                           |
-| EC75     | Java                | Concatenate Strings in loop                        | Optimizations on Java concatenation Strings are useless since JDK8                                       | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/246)                                                                                                                                                                |
 
 ## Refused / Deleted rules
 
@@ -85,3 +81,7 @@ This table lists rules proposed by the community but refused or/and deleted in e
 |----------|----------|------------------------------------------|------------------------------------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | CRDOM203 | HTML     | HTML page must contain a doctype tag     | The difference in performance is negligible, this rule is more related to the user experience.                               | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/103)                                                                                    |
 | CRPYT    | Python   | Use numpy array instead of standard list | The use of numpy library to perform array manipulation is more energy efficient than the use of the standard list functions. | [Github discussion with measures](https://github.com/green-code-initiative/ecoCode/issues/132)                                                                                   |
+| EC4      | Java                | Avoid using global variables                       | Global variables do not exist in Java.                                                                   | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/233)                                                                                                                                                                |
+| EC53     | Java                | Using arrays in foreach loops                      | No good arguments and not enough green measures.                                                         | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/240)                                                                                                                                                                |
+| EC63     | Java                | Unnecessarily assigning values to variables        | There are already 3 native SonarQube rules for Java.                                                     | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/pull/258)                                                                                                                                                                  |
+| EC75     | Java                | Concatenate Strings in loop                        | Optimizations on Java concatenation Strings are useless since JDK8                                       | [Github discussion with sources](https://github.com/green-code-initiative/ecoCode/issues/246)                                                                                                                                                                |
diff --git a/ecocode-rules-specifications/src/main/rules/EC4/EC4.json b/ecocode-rules-specifications/src/main/rules/EC4/EC4.json
diff --git a/ecocode-rules-specifications/src/main/rules/EC4/java/EC4.asciidoc b/ecocode-rules-specifications/src/main/rules/EC4/java/EC4.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC4/java/EC4.json b/ecocode-rules-specifications/src/main/rules/EC4/java/EC4.json
diff --git a/ecocode-rules-specifications/src/main/rules/EC4/php/EC4.asciidoc b/ecocode-rules-specifications/src/main/rules/EC4/php/EC4.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC4/python/EC4.asciidoc b/ecocode-rules-specifications/src/main/rules/EC4/python/EC4.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC63/EC63.json b/ecocode-rules-specifications/src/main/rules/EC63/EC63.json
diff --git a/ecocode-rules-specifications/src/main/rules/EC63/java/EC63.asciidoc b/ecocode-rules-specifications/src/main/rules/EC63/java/EC63.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC63/java/EC63.json b/ecocode-rules-specifications/src/main/rules/EC63/java/EC63.json
diff --git a/ecocode-rules-specifications/src/main/rules/EC75/EC75.json b/ecocode-rules-specifications/src/main/rules/EC75/EC75.json
diff --git a/ecocode-rules-specifications/src/main/rules/EC75/java/EC75.asciidoc b/ecocode-rules-specifications/src/main/rules/EC75/java/EC75.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC75/java/EC75.json b/ecocode-rules-specifications/src/main/rules/EC75/java/EC75.json