fix(equal): regenerate EqualVisitor based on new Scanner, which fixes a number of bugs incl. #978 #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurieux
reviewed
Nov 19, 2016
| biScan(annotationFieldAccess.getTypeCasts(), other.getTypeCasts()); | ||
| biScan(annotationFieldAccess.getTarget(), other.getTarget()); |
There was a problem hiding this comment.
We dont need the target?
tdurieux
reviewed
Nov 19, 2016
| @@ -18,243 +18,275 @@ | |||
|
|
|||
| package spoon.support.visitor.clone; | |||
|
|
|||
| import java.lang.annotation.Annotation; | |||
There was a problem hiding this comment.
Can you disable the autoImport in order to see the important change?
tdurieux
reviewed
Nov 19, 2016
| try { | ||
| assertThat(actual) | ||
| .isEqualTo(expected); | ||
| } catch (AssertionError e) { | ||
| throw new ComparisonFailure("ReplacementVisitor different", expected.toString(), actual.toString()); | ||
| //throw new ComparisonFailure("ReplacementVisitor different", expected.toString(), actual.toString()); |
There was a problem hiding this comment.
please had at least a logger
|
done. mergeable from my point of view, so as to proceed with the next ones. |
tdurieux
reviewed
Nov 21, 2016
| public class EqualsVisitor extends spoon.reflect.visitor.CtAbstractBiScanner { | ||
| public static boolean equals(spoon.reflect.declaration.CtElement element, spoon.reflect.declaration.CtElement other) { | ||
| return !(new spoon.support.visitor.equals.EqualsVisitor().biScan(element, other)); | ||
| public class EqualsVisitor extends CtBiScannerDefault { |
There was a problem hiding this comment.
This class is now manually maintained?
|
Yes. However, it will eventually only contain one |
tdurieux
reviewed
Nov 21, 2016
| CtTry var = factory.Code().createCodeSnippetStatement("try{}catch(RuntimeException | AssertionError e){}").compile(); | ||
| CtTry var2 = var.clone(); | ||
| var2.getCatchers().get(0).getParameter().getMultiTypes().remove(0); | ||
| assertNotEquals(1, var.getComments().size()); |
There was a problem hiding this comment.
this test is not related to comments
There was a problem hiding this comment.
you're right, fixed
… a number of bugs incl. INRIA#978
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #978