fixes bug in printing of new Array with comment #911 #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Pavel, |
|
Hi Martin, |
|
now it breaks a test, could you make it pass? thanks. |
|
I modified the fix by way it keeps formatting of annotations too. |
In case of comment the last character is the last character of the comment and not the " , ". So we have to call printer.removeLastChar(); before comment is added. It is not enough to skip adding " , ", because printer.removeLastChar(); removes EOL added by previous call of scan() too. It influences formatting of spooned code
pvojtechovsky
force-pushed
the
fix-newArray-printer
branch
from
54935d0 to
b8e3c2f
Compare
|
excellent, thanks. We can squash at merge time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of comment the last character is the last character of the
comment and not the ",".