review: test: only run tests with compliance level >=8 #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
changed the title
I-Al-Istannen
approved these changes
Oct 8, 2024
|
LGTM. We can delete them (they are in git) or leave them there as relics/documentation of old bugs. Deleting is probably fine. |
|
Thank you @SirYwell :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #5977, we need to make sure that tests only run with a compliance level >= 8.
I went through the affected tests trying to figure out if there is a specific reason why they used a lower language level. Those where it doesn't seem to make sense to run on higher language levels are disabled now with a comment. I'm not sure if we want to remove them directly.
Note: There are more failing tests in #5977, but the others have different reasons that we need to analyze more closely I guess. That's why I'd like to address them separately.