review: feat: Add newline at file end and refactor type calculation #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A newline has been added to the end of each file by convention. Additionally, the calculate method in DefaultJavaPrettyPrinter has been refactored. The type calculation logic is now cleaner and easier to understand, as unnecessary conditional checks have been removed.
|
This covers a part of #5744 and is a general improvement imo. |
Co-authored-by: I-Al-Istannen <[email protected]>
MartinWitt
changed the title
I-Al-Istannen
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A newline has been added to the end of each file by convention. Additionally, the calculate method in DefaultJavaPrettyPrinter has been refactored. The type calculation logic is now cleaner and easier to understand, as unnecessary conditional checks have been removed.