Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: fix: make getActualField respect static fields in annotations #5238

Merged
merged 2 commits into from
May 30, 2023

Conversation

SirYwell
Copy link
Collaborator

@SirYwell SirYwell commented May 28, 2023

Annotations can have static fields, so looking up a method for them fails. Additionally, it seems like the methods from annotations are never modelled using CtFieldReference, so removing the code doesn't change behavior as far as I was able to find out.

SirYwell added 2 commits May 28, 2023 09:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@SirYwell SirYwell changed the title wip: fix: make getActualField respect static fields in annotations review: fix: make getActualField respect static fields in annotations May 28, 2023
Copy link
Collaborator

@MartinWitt MartinWitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge

@MartinWitt MartinWitt merged commit ef347ef into INRIA:master May 30, 2023
@MartinWitt MartinWitt deleted the fix/getActualField-annotations branch May 30, 2023 12:59
@MartinWitt
Copy link
Collaborator

Thanks @SirYwell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants