chore: Use native transport configuration for Maven in CI #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add system properties to Maven options to set the native dependency transport for Aether connector. This will improve the speed of dependency resolution by using the native transport layer over HTTP. Also, the request timeout and connection timeout are increased to 300,000 milliseconds in order to allow for slower networks.
Removed unnecessary Maven options in the test workflow configuration file. This will simplify the test runs and remove excess configuration code.
|
The removed env var |
The changes made removed the MAVEN_OPTS environment variable from the test jobs in the workflow. This variable was previously set to a specific java version which is now not needed as it is inferred from the matrix configuration. Co-authored-by: I-Al-Istannen <[email protected]>
MartinWitt
force-pushed
the
fix/nativeHttp
branch
from
18b058a to
746037a
Compare
I-Al-Istannen
approved these changes
Apr 25, 2023
|
If you merge this dont remove the coauthor during the squash. |
I-Al-Istannen
changed the title
|
Was a nice ride with wagon. Let's hope the new HTTP native transport is better. |
|
Let's cross our fingers! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #5189 Somehow the GitHub API allows creating branches which destroy GitHub. Having a
/leading your branch name is not the best idea.Had a lengthy discussion with @I-Al-Istannen and @SirYwell about our failing master and how to fix this. We concluded to switch to mavens new http transport and increase the timeout. This should reduce/remove the failing of mavens dependency resolution on master. The timeout is still set to a reasonable number, but we will monitor it closely and increase if we see we still need a large.
Add system properties to Maven options to set the native dependency transport for Aether connector. This will improve the speed of dependency resolution by using the native transport layer over HTTP. Also, the request timeout and connection timeout are increased to 300,000 milliseconds in order to allow for slower networks.