fix: Use a better heuristic for guessing type/field references in no classpath mode #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classpath mode In no classpath mode, JDT only gives us a ProblemBinding with a QualifiedNameReference. We then have to figure out whether this is a type, field, inner class, package or anything else ourselves. Previously, every child of an invocation was treated as a type. This patch changes it to favor fields and only falls back to a type access, if it appeared somewhere in an import. This is still far from perfect, but it at least produces better guesses. Closes INRIA#5151
I-Al-Istannen
changed the title
MartinWitt
reviewed
Apr 13, 2023
| @@ -63,7 +63,7 @@ public static void initializeContext() { | |||
| /* 22 */ "...\n" + | |||
| /* 23 */ "}\n"; | |||
|
|
|||
| ctx = new ZippedCodeBaseTestContext(smpl, "src/test/resources/C4JShouldVibrate.zip", false); | |||
| ctx = new ZippedCodeBaseTestContext(smpl, "src/test/resources/C4JShouldVibrate.zip", true); | |||
There was a problem hiding this comment.
Is there a reason for this change?
There was a problem hiding this comment.
Yes, it makes the test pass.
The test expects types to be imported but did not set the auto-import flag.
MartinWitt
reviewed
Apr 13, 2023
|
Could fix the reording of the imports before we merge? |
I-Al-Istannen
force-pushed
the
fix/issue-5151
branch
from
606d41b to
1669e5a
Compare
MartinWitt
approved these changes
Apr 13, 2023
MartinWitt
changed the title
|
Thanks @I-Al-Istannen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In no classpath mode, JDT only gives us a ProblemBinding with a QualifiedNameReference. We then have to figure out whether this is a type, field, inner class, package or anything else ourselves. Previously, every child of an invocation was treated as a type. This patch changes it to favor fields and only falls back to a type access, if it appeared somewhere in an import.
This is still far from perfect, but it at least produces better guesses.
Closes #5151