Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: chore(actions): add pom quality checker to github actions #5164

Merged
merged 5 commits into from
Apr 18, 2023

Conversation

MartinWitt
Copy link
Collaborator

This PR adds 2 checks to our CI. First we check if the doc has no error and second if the pom follows all the rules for maven central. We should be already fulfilling this all, but checking it on every commit seems useful.

@MartinWitt
Copy link
Collaborator Author

Hmm I am unsure if only jreleaser/pomchecker want the developer tag non-empty. Sonatype itself also isn't clear there: https://central.sonatype.org/publish/requirements/#developer-information

@MartinWitt
Copy link
Collaborator Author

Okay I have 2 solutions: Either we mention the original spoon authors or simply add all current integrators in it. Any comments or other solutions?

@I-Al-Istannen
Copy link
Collaborator

Developers are presumably members of the project's core development. Note that, although an organization may have many developers (programmers) as members, it is not good form to list them all as developers, but only those who are immediately responsible for the code. A good rule of thumb is, if the person should not be contacted about the project, they do not need to be listed here.

From https://maven.apache.org/pom.html#Developers would suggest listing the integrators, or at least some of them.

@MartinWitt
Copy link
Collaborator Author

I have added all integrators with minimal information. If someone wants to include more information, feel free to PR it or comment here.

@MartinWitt
Copy link
Collaborator Author

The hashes for the actions are missing but renovate should instantly add them after a merge.

@MartinWitt MartinWitt changed the title chore(actions): add pom quality checker to github actions review: chore(actions): add pom quality checker to github actions Apr 12, 2023
@monperrus monperrus merged commit a2665ab into INRIA:master Apr 18, 2023
@monperrus
Copy link
Collaborator

thanks @MartinWitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants