fix: Remove escaping of ' in a CtLiteral<String> #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only relevant for CtLiterals without a position. In strings escaping ' is not necessary.
|
I could create another method overload(1) to fix the constant value warning. But this would increase the size of the class unnecessary. Any opinions? (1) Actually this is not a method overload because the methods are static |
MartinWitt
changed the title
MartinWitt
changed the title
The method seems to be package private, why do you need to keep it if it is never called? |
|
I thought about the one guy creating his code inside the same package in his project. I can remove this method if we ignore that one guy. |
|
Yes, I would ignore them. |
MartinWitt
force-pushed
the
bug/tooStrictEscaping
branch
from
8d035c0 to
62b9300
Compare
MartinWitt
commented
Mar 5, 2023
I-Al-Istannen
requested changes
Mar 5, 2023
I-Al-Istannen
approved these changes
Apr 6, 2023
I-Al-Istannen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, spoon escapes every
'in aCtLiteral<String>without a source position. In astringescaping'is not necessary.