test: migrate ContractOnSettersParametrizedTest to JUnit 5 #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following has changed in the code: Replaced junit 4 test annotation with junit 5 test annotation in testContract Transformed junit4 assert to junit 5 assertion in testContract
monperrus
reviewed
Jan 24, 2022
| public Collection<DynamicTest> data() { | ||
| List<DynamicTest> values = new ArrayList<>(); | ||
| for (CtType<?> t : allInstantiableMetamodelInterfaces) { | ||
| if (!(CtReference.class.isAssignableFrom(t.getActualClass()))) { |
There was a problem hiding this comment.
why do we need this extra condition?
There was a problem hiding this comment.
I copied the called method from here
and adapted it to create DynamicTests. The methodcreateReceiverList is used in other test classes and therefore wasn't easy to change. Why createReceiverList has this check is not clear to me but it seems that is your code? #956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3919
while refactoring, I removed an unused field and moved the fields to the top