Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate AnnotationPositionTest to JUnit 5 #4559

Merged

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

Junit4-@ignore

The JUnit 4 @Ignore annotation should be replaced with JUnit 5 @Disabled annotation.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testUsageOfTypeAnnotationOnParameterInMethod
  • Replaced junit 4 test annotation with junit 5 test annotation in testSneakyAnnotationsOnParameters

Junit4-@ignore

  • Replaced @Ignore annotation with @Disabled at method testUsageOfTypeAnnotationOnParameterInMethod
  • Replaced @Ignore annotation with @Disabled at method testSneakyAnnotationsOnParameters

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testUsageOfTypeAnnotationOnParameterInMethod
  • Transformed junit4 assert to junit 5 assertion in testSneakyAnnotationsOnParameters

 The following has changed in the code:
Replaced @ignore annotation with @disabled at method testUsageOfTypeAnnotationOnParameterInMethod
Replaced @ignore annotation with @disabled at method testSneakyAnnotationsOnParameters
Replaced junit 4 test annotation with junit 5 test annotation in testUsageOfTypeAnnotationOnParameterInMethod
Replaced junit 4 test annotation with junit 5 test annotation in testSneakyAnnotationsOnParameters
Transformed junit4 assert to junit 5 assertion in testUsageOfTypeAnnotationOnParameterInMethod
Transformed junit4 assert to junit 5 assertion in testSneakyAnnotationsOnParameters
@monperrus monperrus merged commit e86157a into INRIA:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants