test: migrate InitializerTest to JUnit 5 #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following has changed in the code: Replaced junit 4 test annotation with junit 5 test annotation in testModelBuildingStaticInitializer Replaced junit 4 test annotation with junit 5 test annotation in testModelBuildingInitializer Replaced junit 4 test annotation with junit 5 test annotation in testModelBuildingInitializerNoclasspath Transformed junit4 assert to junit 5 assertion in testModelBuildingStaticInitializer Transformed junit4 assert to junit 5 assertion in testModelBuildingInitializer Transformed junit4 assert to junit 5 assertion in testModelBuildingInitializerNoclasspath
monperrus
reviewed
Jan 17, 2022
| @@ -48,8 +48,11 @@ public void testModelBuildingStaticInitializer() throws Exception { | |||
| assertEquals(1, staticBlock.getBody().getStatements().size()); | |||
|
|
|||
| // this fails: regression or known bug? | |||
There was a problem hiding this comment.
let's remove this commented code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3919
Change Log
The following bad smells are refactored:
JUnit4-@test
The JUnit 4
@Testannotation should be replaced with JUnit 5@Testannotation.JUnit4Assertion
The JUnit4 assertion should be replaced with JUnit5 Assertions.
The following has changed in the code:
JUnit4-@test
testModelBuildingStaticInitializertestModelBuildingInitializertestModelBuildingInitializerNoclasspathJUnit4Assertion
testModelBuildingStaticInitializertestModelBuildingInitializertestModelBuildingInitializerNoclasspath