Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate NullParentTest to JUnit 5 #4507

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

Junit4-@before

The JUnit 4 @Before annotation should be replaced with JUnit 5 @BeforeEach annotation.

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testTargetedAccessNullTarget
  • Replaced junit 4 test annotation with junit 5 test annotation in testTargetedExpressionNullTarget
  • Replaced junit 4 test annotation with junit 5 test annotation in testAssertNullExpression
  • Replaced junit 4 test annotation with junit 5 test annotation in testForLoopNullChildren
  • Replaced junit 4 test annotation with junit 5 test annotation in testIfNullBranches
  • Replaced junit 4 test annotation with junit 5 test annotation in testLocalVariableNullDefaultExpression
  • Replaced junit 4 test annotation with junit 5 test annotation in testFieldNullDefaultExpression
  • Replaced junit 4 test annotation with junit 5 test annotation in testReturnNullExpression

Junit4-@before

  • Replaced @Before annotation with @BeforeEach at method setup

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testTargetedAccessNullTarget
  • Transformed junit4 assert to junit 5 assertion in testTargetedExpressionNullTarget
  • Transformed junit4 assert to junit 5 assertion in testAssertNullExpression
  • Transformed junit4 assert to junit 5 assertion in testForLoopNullChildren
  • Transformed junit4 assert to junit 5 assertion in testIfNullBranches
  • Transformed junit4 assert to junit 5 assertion in testLocalVariableNullDefaultExpression
  • Transformed junit4 assert to junit 5 assertion in testFieldNullDefaultExpression
  • Transformed junit4 assert to junit 5 assertion in testReturnNullExpression

 The following has changed in the code:
Replaced @before annotation with @beforeeach at method setup
Replaced junit 4 test annotation with junit 5 test annotation in testTargetedAccessNullTarget
Replaced junit 4 test annotation with junit 5 test annotation in testTargetedExpressionNullTarget
Replaced junit 4 test annotation with junit 5 test annotation in testAssertNullExpression
Replaced junit 4 test annotation with junit 5 test annotation in testForLoopNullChildren
Replaced junit 4 test annotation with junit 5 test annotation in testIfNullBranches
Replaced junit 4 test annotation with junit 5 test annotation in testLocalVariableNullDefaultExpression
Replaced junit 4 test annotation with junit 5 test annotation in testFieldNullDefaultExpression
Replaced junit 4 test annotation with junit 5 test annotation in testReturnNullExpression
Transformed junit4 assert to junit 5 assertion in testTargetedAccessNullTarget
Transformed junit4 assert to junit 5 assertion in testTargetedExpressionNullTarget
Transformed junit4 assert to junit 5 assertion in testAssertNullExpression
Transformed junit4 assert to junit 5 assertion in testForLoopNullChildren
Transformed junit4 assert to junit 5 assertion in testIfNullBranches
Transformed junit4 assert to junit 5 assertion in testLocalVariableNullDefaultExpression
Transformed junit4 assert to junit 5 assertion in testFieldNullDefaultExpression
Transformed junit4 assert to junit 5 assertion in testReturnNullExpression
@monperrus monperrus merged commit 48efccf into INRIA:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants