Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate ParentTest to JUnit 5 #4506

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

Junit4-@before

The JUnit 4 @Before annotation should be replaced with JUnit 5 @BeforeEach annotation.

Junit4-@ignore

The JUnit 4 @Ignore annotation should be replaced with JUnit 5 @Disabled annotation.

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testParent
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentSet
  • Replaced junit 4 test annotation with junit 5 test annotation in testAddType
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentOfCtPackageReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentOfCtVariableReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentOfCtExecutableReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentOfGenericInTypeReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentOfPrimitiveReference
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetParentWithFilter
  • Replaced junit 4 test annotation with junit 5 test annotation in testHasParent
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentSetInSetter
  • Replaced junit 4 test annotation with junit 5 test annotation in testParentNotInitializedException
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetParentOverloadsInNoParentElements
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetParentOverloadsWithNoMatchingElements

Junit4-@ignore

  • Replaced @Ignore annotation with @Disabled at method testParentSetInSetter

Junit4-@before

  • Replaced @Before annotation with @BeforeEach at method setup

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testParent
  • Transformed junit4 assert to junit 5 assertion in testParentSet
  • Transformed junit4 assert to junit 5 assertion in testAddType
  • Transformed junit4 assert to junit 5 assertion in testParentOfCtPackageReference
  • Transformed junit4 assert to junit 5 assertion in testParentOfCtVariableReference
  • Transformed junit4 assert to junit 5 assertion in testParentOfCtExecutableReference
  • Transformed junit4 assert to junit 5 assertion in testParentOfGenericInTypeReference
  • Transformed junit4 assert to junit 5 assertion in testParentOfPrimitiveReference
  • Transformed junit4 assert to junit 5 assertion in testGetParentWithFilter
  • Transformed junit4 assert to junit 5 assertion in testHasParent
  • Transformed junit4 assert to junit 5 assertion in checkAddStrategy
  • Transformed junit4 assert to junit 5 assertion in checkSetStrategy
  • Transformed junit4 assert to junit 5 assertion in testGetParentOverloadsInNoParentElements
  • Transformed junit4 assert to junit 5 assertion in testGetParentOverloadsWithNoMatchingElements

 The following has changed in the code:
Replaced @before annotation with @beforeeach at method setup
Replaced @ignore annotation with @disabled at method testParentSetInSetter
Replaced junit 4 test annotation with junit 5 test annotation in testParent
Replaced junit 4 test annotation with junit 5 test annotation in testParentSet
Replaced junit 4 test annotation with junit 5 test annotation in testAddType
Replaced junit 4 test annotation with junit 5 test annotation in testParentOfCtPackageReference
Replaced junit 4 test annotation with junit 5 test annotation in testParentOfCtVariableReference
Replaced junit 4 test annotation with junit 5 test annotation in testParentOfCtExecutableReference
Replaced junit 4 test annotation with junit 5 test annotation in testParentOfGenericInTypeReference
Replaced junit 4 test annotation with junit 5 test annotation in testParentOfPrimitiveReference
Replaced junit 4 test annotation with junit 5 test annotation in testGetParentWithFilter
Replaced junit 4 test annotation with junit 5 test annotation in testHasParent
Replaced junit 4 test annotation with junit 5 test annotation in testParentSetInSetter
Replaced junit 4 test annotation with junit 5 test annotation in testParentNotInitializedException
Replaced junit 4 test annotation with junit 5 test annotation in testGetParentOverloadsInNoParentElements
Replaced junit 4 test annotation with junit 5 test annotation in testGetParentOverloadsWithNoMatchingElements
Transformed junit4 assert to junit 5 assertion in testParent
Transformed junit4 assert to junit 5 assertion in testParentSet
Transformed junit4 assert to junit 5 assertion in testAddType
Transformed junit4 assert to junit 5 assertion in testParentOfCtPackageReference
Transformed junit4 assert to junit 5 assertion in testParentOfCtVariableReference
Transformed junit4 assert to junit 5 assertion in testParentOfCtExecutableReference
Transformed junit4 assert to junit 5 assertion in testParentOfGenericInTypeReference
Transformed junit4 assert to junit 5 assertion in testParentOfPrimitiveReference
Transformed junit4 assert to junit 5 assertion in testGetParentWithFilter
Transformed junit4 assert to junit 5 assertion in testHasParent
Transformed junit4 assert to junit 5 assertion in testGetParentOverloadsInNoParentElements
Transformed junit4 assert to junit 5 assertion in testGetParentOverloadsWithNoMatchingElements
@monperrus monperrus merged commit 075c8f5 into INRIA:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants