Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate LoopSniperJavaPrettyPrinterTest to JUnit 5 #4500

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

Junit4-@BeforeClass

The JUnit 4 @BeforeClass annotation should be replaced with JUnit 5 @BeforeAll annotation.

Junit4-@ignore

The JUnit 4 @Ignore annotation should be replaced with JUnit 5 @Disabled annotation.

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4-AssertThat

AssertThat in Junit 4 is deprecated. Use AssertThat in Hamcrest instead.

The following has changed in the code:

Junit4-@BeforeClass

  • Replaced @BeforeClass annotation with @BeforeAll at method setup

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in forNoBraces
  • Replaced junit 4 test annotation with junit 5 test annotation in forEachBraces
  • Replaced junit 4 test annotation with junit 5 test annotation in whileNoBraces
  • Replaced junit 4 test annotation with junit 5 test annotation in whileWithBraces

JUnit4-AssertThat

  • Replaced Assert.assertThat with MatcherAssert.assertThat in runSniperJavaPrettyPrinter
  • Replaced Assert.assertThat with MatcherAssert.assertThat in runSniperJavaPrettyPrinter
  • Replaced Assert.assertThat with MatcherAssert.assertThat in runSniperJavaPrettyPrinter

Junit4-@ignore

  • Replaced @Ignore annotation with @Disabled at method whileWithBraces

 The following has changed in the code:
Replaced @BeforeClass annotation with @BeforeAll at method setup
Replaced @ignore annotation with @disabled at method whileWithBraces
Replaced junit 4 test annotation with junit 5 test annotation in forNoBraces
Replaced junit 4 test annotation with junit 5 test annotation in forEachBraces
Replaced junit 4 test annotation with junit 5 test annotation in whileNoBraces
Replaced junit 4 test annotation with junit 5 test annotation in whileWithBraces
Replaced Assert.assertThat with MatcherAssert.assertThat in runSniperJavaPrettyPrinter
Replaced Assert.assertThat with MatcherAssert.assertThat in runSniperJavaPrettyPrinter
Replaced Assert.assertThat with MatcherAssert.assertThat in runSniperJavaPrettyPrinter
@slarse slarse merged commit fbbc88a into INRIA:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants