Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MavenLauncher): maximum recovery from missing libraries #4336

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

henryhchchc
Copy link
Contributor

The way Spoon build the class path for a Maven project in MavenLauncher is to launch mvn dependencies:build-classpath to generate a text file containing class path. However, for multi-module projects, when there is a module whose dependencies can not be resolved, Maven will skip the remaining modules and report an error.

In this PR, I added the -fn flag to the Maven invocation request such that Maven can continue to resolve dependencies for the remaining modules even though there is an error occurred. This can help resolve as many libraries as possible.

@henryhchchc henryhchchc changed the title review: fix: Recovery as many libraries as possible review: fix: recovery as many libraries as possible Dec 7, 2021
@monperrus
Copy link
Collaborator

Thanks for the contribution @henryhchchc

LGTM.

@nharrand may be the expert integrator for this.

@monperrus monperrus changed the title review: fix: recovery as many libraries as possible fix(MavenLauncher): maximum recovery from missing libraries Dec 10, 2021
@monperrus monperrus merged commit fd8060c into INRIA:master Dec 10, 2021
@monperrus
Copy link
Collaborator

thanks @henryhchchc for your contribution

@henryhchchc henryhchchc deleted the maven-launcher-fix branch December 10, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants