Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dependency rg.tukaani:xz should have a test scope #3832

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix: dependency rg.tukaani:xz should have a test scope #3832

merged 1 commit into from
Mar 12, 2021

Conversation

cesarsotovalero
Copy link
Contributor

Fix #3831

@cesarsotovalero cesarsotovalero mentioned this pull request Mar 11, 2021
Closed
@monperrus
Copy link
Collaborator

Indeed, XZ support is not implemented, see https://github.com/INRIA/spoon/blob/master/src/main/java/spoon/support/SerializationModelStreamer.java#L65

LGTM, will merge, thanks a lot @cesarsotovalero

@monperrus monperrus changed the title fix: Dependency should have a test scope fix: dependency rg.tukaani:xz should have a test scope Mar 12, 2021
@monperrus monperrus merged commit 047df3d into INRIA:master Mar 12, 2021
@monperrus
Copy link
Collaborator

thanks for your contribution @cesarsotovalero you're really a dependency king :)

@monperrus monperrus mentioned this pull request Mar 16, 2021
Closed
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
@cesarsotovalero @woutersmeenk
fix: dependency rg.tukaani:xz should have a test scope (INRIA#3832)
7136e0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency should have a test scope
2 participants
@cesarsotovalero @monperrus