refactor: throw informative exception when sniper printing cannot be done #3764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3760
See #3760 for a description of the problem. I think it's more work than it's worth to try to allow for sniper printing of a subset of a compilation unit's types. There's an initial problem in that DJPP clones the CU if it discovers that one is trying to print only a subset of the types (this is where the current crash described in #3760 comes from). Even working around that, there's still a bit of trickery involved in printing just a subset of the types. A couple more hours on this and I could probably solve it, but I just don't think it's worth it.
This PR just throws a more informative exception that looks like this:
I'm not quite sure if "fix" is the correct label for this PR, feel free to re-label.