Fix: fix pretty-printing of imports for static methods #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @danglotb ! Are you trying to fix it? |
|
Hi @monperrus, I'll investigate how to. Does the test seem correct? Do you think I can use it as a base to fix the issue? |
|
Hi, @monperrus. Here my attempt. This pull-request closes #3214 and maybe it closes #3618. |
monperrus
reviewed
Dec 5, 2020
| @@ -85,7 +85,7 @@ protected void handleTargetedExpression(CtTargetedExpression<?, ?> targetedExpre | |||
| return; | |||
| } | |||
|
|
|||
| if (target != null && target.isImplicit()) { | |||
| if (target.isImplicit()) { | |||
There was a problem hiding this comment.
What about keeping target != null to avoid crashing with NPE on target.isImplicit?
There was a problem hiding this comment.
This check is redundant with the check just above(here):
if (target == null) {
...
return;
}If target == null, the condition target.isImplicit() will not be hit, isn't?
|
OK for me. Unwip? Ready for merge? |
danglotb
changed the title
monperrus
changed the title
|
Thanks a lot @danglotb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm opening this pull-request that contains a test to reproduce the bug reported in #3618 and #3214.
Thank you