fix: Fix NullPointerException in SniperJavaPrettyPrinter.printTypes #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
|
This is ready for review. |
slarse
changed the title
|
Thanks! LGTM, will merge after the typical one-day latency for everybody to see it. |
monperrus
changed the title
|
Thanks a lot @slarse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3675
This PR fixes the problem explained in #3675 by overriding
printTypesinSniperJavaPrettyPrinter, and trying to resolve a compilation unit from the types passed in. If no compilation unit can be found, or the types have mismatching compilation units, it raises an exception. Two new tests verify the behavior within a reasonable amount of certainty.