-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add CtModifiable#isTransient and related methods #3670
feature: add CtModifiable#isTransient and related methods #3670
Conversation
…e, Synchronized, Native, Strictfp)
LGTM, nice work! |
Thank you! |
Hi @Artamm In Spoon we aim at strongly testing all functionalities. Could you add test cases to specify those new methods? Thanks! |
@monperrus , thank you for your response. |
Thanks a lot @Artamm , that's good testing. Do you confirm that we test all those new methods with both "true" and "false"? |
@monperrus, I think yes, these tests are enough to cover all cases for new methods. |
Big thanks for your contribution @Artamm and thanks a lot @MartinWitt for the shepherding |
fix #3651
Implemented modifiers from ModifierKind (
Transient
,Volatile
,Synchronized
,Native
,Strictfp
) for CtModifiable class.