Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP feature(spoon-kotlin): Support for analysis and transformation of Kotlin code #3577

Closed
wants to merge 423 commits into from
Closed

WIP feature(spoon-kotlin): Support for analysis and transformation of Kotlin code #3577

wants to merge 423 commits into from

Conversation

jlundhol
Copy link

@jlundhol jlundhol commented Sep 8, 2020

Draft PR suggested by @monperrus. Early work in progress for #2554.

Currently in experimental state with minimal additions to the underlying model.

@jlundhol
Remove wrong match for invoke operator
f7ba99d
@jlundhol
Add tests for assert not null and safe calls
c460b6e
@jlundhol
Implement (build and print) local functions
46ccaa5
@jlundhol
Add support for named arguments
a49bb97
@jlundhol
Fix vararg type would be Array
ace84d0
@jlundhol
Add support for safe assignment and access
c407b8b
@jlundhol
Change HOF forEach to loop
e7fe9f2
@jlundhol
Add type param support for methods
1a97446
@jlundhol
Add TypeParameterHandler and support for printing variance
a7f4474
@jlundhol
Add support for type parameters in classes
12bc9cc
@jlundhol
Fix type parameters without variance
4e40e2b
@jlundhol
Add type parameters to classes
9351eb9
@jlundhol
Add support for type arguments to invocations
72ed2bc
@jlundhol
Add support type parameter references
beb555b
@jlundhol
Add fromTypeVariable
b58b56d
@jlundhol
Fix missing variance when printing type variables
c75a15b
@jlundhol
Implement (print) CtTypeParameter and CtTypeParameterRef
2225990
@jlundhol
Add support for type arguments in variable write and invocation
721573f
@jlundhol
Fix some type references not being marked as implicit
e67acd5
@jlundhol
Add visitTypeArgumentsList
c5596e2
@jlundhol
Add doc
c762757
@jlundhol
Add initial generics tests
5ecac7d
@jlundhol
Add test for implicit type argument
1b586d3
@jlundhol
Add use of extension receiver
7b93cdf
@jlundhol
Implement (build and print) when-expressions
2a81265
@jlundhol
Fix legacy isIf not respecting when-expr
2d4c060
@jlundhol
Fix implicit LHS of in operator, remove legacy impl_LHS invocation type
fe59d3b
@jlundhol
Correct doc for visitExpressionsPreOrder
0d2b8c2
@jlundhol
Change printing of empty block to "{}", update affected tests
9f85eb4
@jlundhol
Revert to destructuring declaration after InvocationType change
0c1da4e
@jlundhol
Fix some typeRef creations ignoring resolveGenerics
ac05b78
@jlundhol
Fix constructor value args not resolving generics
b7b967d
@jlundhol
Fix destructuring declaration crashing when RHS is statement
771b7bb
@jlundhol
Fix missing superclass when subclass doesn't have a primary constructor
973b556
@jlundhol
Fix compareTo operator having an extra comparison
80e983d
@jlundhol
Add support for extension function types
848630a
@jlundhol
Fix class reference LHS sometimes have type args
d9b7cd2
@jlundhol
Fix lambda outside param list on constructor calls
5a85b3f
@jlundhol
Fix problem with invoke with implicit receiver argument
3a0d46b
@jlundhol
Fix setting field doesn't have receiver
def9e6b
@jlundhol
Make flexible types inferred to prevent inference problems
0ee0ba9
@jlundhol
Add support for cascading If
e3f720e
@jlundhol
Fix jump statements not having types
c18c707
@jlundhol
Fix star projection not printing asterisk
de5100e
@jlundhol
Fix crash due to missing statementExpression
467eb30
@jlundhol
Fix printing of nested type arguments
79219a1
@jlundhol
Fix StatementExpression isImplicit() not being transparent
b1d5762
@jlundhol
Add 'import' as java clash identifier
5ed3fe8
@jlundhol
Mark local types to fix error when referencing them
279c484
@jlundhol
Prevent lambda being printed outside parenthesis if vararg
b447bf9
@jlundhol
Fix crash due to extension receiver for some binary operators
6346b3e
@jlundhol
Parenthesise If-expressions
66db311
@jlundhol
Remove temporary MsgCollector
d7e9b21
@jlundhol
Fix building of executable references not respecting actual signature
2474b6a
@jlundhol
Remove redundant metadata top_level_declaring_cu
25a7651
@jlundhol
Update rules for checking if argument is movable lambda
a1bea26
@monperrus
Copy link
Collaborator

Nice work!

@aemoncannon
Copy link

Just curious what is the status of this PR? Does it need help? Best

@jlundhol jlundhol closed this Mar 20, 2021
@jlundhol
Copy link
Author

Sorry for the late reply aemoncannon.
This PR was part of a master thesis project to see to what extent the current model could be reused.
The result in the forked repo is not very usable towards the goal of #2554 as structural differences in the languages make the modelling of Kotlin code using the existing model somewhat awkward. It can however still be used as inspiration for a future implementation. So I'm closing this draft PR for now, to reflect that I'm not currently working on it and that a new implementation based on an adapted model is likely needed.

Also, a new tree builder implementation would probably do best in using the new FIR module of the Kotlin compiler as opposed to my fork which uses the lower level IR.

I will likely pick this up again in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlundhol @monperrus @aemoncannon