Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added vscode files to .gitignore #3560

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Sep 1, 2020

As requested in #3549 (comment)

@monperrus
Copy link
Collaborator

Thanks. It seems to me that *.gradle would remove build.gradle. WDYT?

@Strum355
Copy link
Contributor Author

Strum355 commented Sep 1, 2020

I did this under the assumption that spoon would be staying with Maven and not using Gradle or both (having to maintain both Maven and Gradle files). If something else is under consideration, I'd be happy to adjust for it

@monperrus
Copy link
Collaborator

FYI, we already have some gradle in subprojects, see https://github.com/INRIA/spoon/blob/master/spoon-dataflow/build.gradle

@Strum355
Copy link
Contributor Author

Strum355 commented Sep 1, 2020

Is it desirable to not gitignore gradle files at the root of the repo which exists as a maven project? If so, I can amend the gitignore to reflect that.
As it currently exists, these gitignore changes only affect from the root of the repo, so the files in spoon-dataflow/ would be unaffected.

@monperrus
Copy link
Collaborator

let's ignore vscode only, to avoid confusion

@Strum355 Strum355 changed the title Added vscode and gradle files to .gitignore Added vscode files to .gitignore Sep 1, 2020
@monperrus monperrus changed the title Added vscode files to .gitignore chore: added vscode files to .gitignore Sep 2, 2020
@monperrus monperrus merged commit 1dda006 into INRIA:master Sep 2, 2020
@monperrus
Copy link
Collaborator

Thanks!

Strum355 added a commit to Strum355/spoon that referenced this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants