fix: fixed identifier correctness check when simplenamePart == ""

src/main/java/spoon/support/reflect/reference/CtReferenceImpl.java

@@ -93,22 +93,22 @@ public boolean equals(Object o) {
 		return false;
 	}
 	private void checkIdentiferForJLSCorrectness(String simplename) {
-	/*
-  * At the level of the Java Virtual Machine, every constructor written in the Java programming language (JLS §8.8)
-  * appears as an instance initialization method that has the special name <init>.
-  * This name is supplied by a compiler. Because the name is not a valid identifier,
-  * it cannot be used directly in a program written in the Java programming language.
-  */
-	//JDTTreeBuilderHelper.computeAnonymousName returns "$numbers$Name" so we have to skip them if they start with numbers
-	//allow empty identifier because they are sometimes used.
+		/*
+		 * At the level of the Java Virtual Machine, every constructor written in the Java programming language (JLS §8.8)
+		 * appears as an instance initialization method that has the special name <init>.
+		 * This name is supplied by a compiler. Because the name is not a valid identifier,
+		 * it cannot be used directly in a program written in the Java programming language.
+		 */
+		//JDTTreeBuilderHelper.computeAnonymousName returns "$numbers$Name" so we have to skip them if they start with numbers
+		//allow empty identifier because they are sometimes used.
 		if (!simplename.matches("<.*>|\\d.*|^.{0}$")) {
 			//split at "<" and ">" because "Iterator<Cache.Entry<K,Store.ValueHolder<V>>>" submits setSimplename ("Cache.Entry<K")
 			String[] splittedSimplename = simplename.split("\\.|<|>");
 			if (checkAllParts(splittedSimplename)) {
 				throw new SpoonException("Not allowed javaletter or keyword in identifier found. See JLS for correct identifier. Identifier: " + simplename);
 			}
+		}
 	}
-}
 	private boolean isKeyword(String simplename) {
 		return keywords.contains(simplename);
 	}
@@ -122,20 +122,26 @@ private boolean checkAllParts(String[] simplenameParts) {
 			}
 			if (isKeyword(simpleName) || checkIdentifierChars(simpleName)) {
 				return true;
+			}
 		}
-	}
-	return false;
+		return false;
 	}
 	private boolean checkIdentifierChars(String simplename) {
-		return (!Character.isJavaIdentifierStart(simplename.charAt(0))) || simplename.chars().anyMatch(letter -> !Character.isJavaIdentifierPart(letter));
+		if (simplename.length() == 0) {
+			return false;
+		}
+		return (!Character.isJavaIdentifierStart(simplename.charAt(0)))
+			|| simplename.chars().anyMatch(letter -> !Character.isJavaIdentifierPart(letter)
+		);
 	}
+
 	private static Collection<String> fillWithKeywords() {
-	//removed types because needed as ref: "int","short", "char", "void", "byte","float", "true","false","boolean","double","long","class", "null"
-	return Stream.of("abstract", "continue", "for", "new", "switch", "assert", "default", "if", "package", "synchronized",  "do", "goto", "private",
-	"this", "break",  "implements", "protected", "throw", "else", "import", "public", "throws", "case", "enum", "instanceof", "return",
-	"transient", "catch", "extends", "try", "final", "interface", "static", "finally",  "strictfp", "volatile",
-	"const",  "native", "super", "while", "_")
-	.collect(Collectors.toCollection(HashSet::new));
+		//removed types because needed as ref: "int","short", "char", "void", "byte","float", "true","false","boolean","double","long","class", "null"
+		return Stream.of("abstract", "continue", "for", "new", "switch", "assert", "default", "if", "package", "synchronized",  "do", "goto", "private",
+			"this", "break",  "implements", "protected", "throw", "else", "import", "public", "throws", "case", "enum", "instanceof", "return",
+			"transient", "catch", "extends", "try", "final", "interface", "static", "finally",  "strictfp", "volatile",
+			"const",  "native", "super", "while", "_")
+			.collect(Collectors.toCollection(HashSet::new));
 	}
 
 	/**

src/test/java/spoon/generating/CorrectIdentifierTest.java

@@ -1,13 +1,16 @@
 package spoon.generating;
 
-import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
-import static org.junit.jupiter.api.Assertions.assertThrows;
 import org.junit.Ignore;
 import org.junit.Test;
 import spoon.FluentLauncher;
 import spoon.Launcher;
 import spoon.SpoonException;
 import spoon.reflect.reference.CtLocalVariableReference;
+import spoon.reflect.reference.CtTypeReference;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
 /**
  * for correct identifier see JLS chapter 3.8 and for keywords 3.9.
  * Ignored tests because we have to cut some corners between spec and jdt.
@@ -76,4 +79,10 @@ public void intersectionTypeIdentifierTest() {
 		//contract: intersectionTypes can have simpleNames with '?' for wildcards.
 		assertDoesNotThrow(() -> new FluentLauncher().inputResource("./src/test/resources/identifier/InliningImplementationMatcher.java").buildModel());
 	}
+
+	@Test
+	public void correctSquareBrackets() {
+		CtTypeReference localVariableRef = new Launcher().getFactory().createTypeReference();
+		assertDoesNotThrow(() -> localVariableRef.setSimpleName("List<String>[]"));
+	}
 }