feature: add support for parallel processor #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's really cool! |
MartinWitt
changed the title
|
i think the feature is finished if no one sees any problems? |
|
Great progress. In Spoon, each time we add a feature, we document it in the In Spoon, we try to add a line Thanks! |
monperrus
reviewed
Mar 6, 2020
| * @param numberOfProcessors number of concurrent running processors. | ||
| * @throws IllegalArgumentException if numberOfProcessors is less than 1. | ||
| */ | ||
| public AbstractParallelProcessor(Consumer<E> processFunction, int numberOfProcessors) { |
|
For both failing test cases see #3289 (?) and wait with merges till it is resolved? |
|
Thanks a lot @MartinWitt |
|
For the record, #1111 is related to this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2659
The new class allows parallel processing for stateless processors. Subtyping processor allows easy usage in launcher and keeps it simple for the user.
Currently the are still some problems and needed changes:
wdyt about it?