fix(spoon-control-flow): add switchExpression to visitor #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Could you add a test that covers this? |
|
it's only a stub adding the not overriden method. An empty method cant be tested or? |
monperrus
changed the title
|
That's the right fix to make spoon-control-flow compile, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the ControlFlowBuilder doesn't override the method
public <T, S> void visitCtSwitchExpression(CtSwitchExpression<T, S> switchExpression). With this fix the CI should work again, as soon as the latest snapshot with the merged switchexpressions #3259 is published on mavencentral. As soon as the new version is published this patch should compile. Updated version of spoon dependency, because CI is using the newest anyway.Edit: Seems like the CI already has the newest version.